[Android] Adds 16KB support #9683
Conversation
Google now requires all Android apps to support 16KB page sizes until November to remain eligible for publishing on the Play Store. This commit updates the Kotlin version, NDK, target and compile SDK versions, as well all third-party dependencies used by the apps, making our Apps compatibility with 16KB page size support. Closes #9679
| applicationId = "de.tutao.calendar" | ||
| minSdk = 26 | ||
| targetSdk = 35 | ||
| targetSdk = 36 |
There was a problem hiding this comment.
do we have to raise target SDK already?
https://developer.android.com/about/versions/16/behavior-changes-16
We currently opt out of edge-to-edge if I remember right and it's going away
https://developer.android.com/about/versions/16/behavior-changes-16#edge-to-edge
I'm also not sure we do the back gesture right still?
https://developer.android.com/about/versions/16/behavior-changes-16#predictive-back
Do we need to handle local network for debugging?
https://developer.android.com/about/versions/16/behavior-changes-16#local-network-permission
There was a problem hiding this comment.
True, we must solve Edge to Edge bugs first. Some stuff shows behind the navigation bar :/ I moved back to 35.
Regarding the other points:
- The back gesture we already do it in the right way and I also updated the Activity lib, as recommended;
- The app seems to be working fine within our local network.
|
|
||
| buildscript { | ||
| ext.kotlin_version = '2.0.0' | ||
| ext.kotlin_version = '2.2.20' |
There was a problem hiding this comment.
I checked and it seems like there should be no changes that break things for us which is good
| } | ||
| } | ||
| ndkVersion = "26.1.10909125" | ||
| ndkVersion = "28.2.13676358" |
There was a problem hiding this comment.
there are quite a few places where we might need to update the ndk version as well…
here is one:
you said you needed a new flag for it as well. We also check in the compiled artifact for it so you need to rebuild it I guess.
there's also a change on F-Droid side that we should not forget:
https://gitlab.com/fdroid/fdroiddata/-/blob/b42b43252a71167333dc7e20536c5e41cf085712/metadata/de.tutao.tutanota.yml#L4857
There was a problem hiding this comment.
As we saw, sqlchipher adopts the use of flags in Application.mk, making the NDK update on our fork not needed.
Regarding F-Droid, I'll create a PR on their side.
Unfortunately we still have some pending changes that we must do before upgrading to 36.
andrehgdias
force-pushed
the
dev-calendar
branch
from
6a6d18b to
c70daf8
Compare
2 participants
Google now requires all Android apps to support 16KB page sizes until November to remain eligible for publishing on the Play Store.
This commit updates the Kotlin version, NDK, target and compile SDK versions, as well all third-party dependencies used by the apps, making our Apps compatibility with 16KB page size support.
Closes #9679