callback: add missing struct fields #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demget
requested changes
Feb 20, 2024
callback.go
Outdated
| @@ -26,6 +26,15 @@ type Callback struct { | |||
| // a bad client can send arbitrary data in this field. | |||
| Data string `json:"data"` | |||
|
|
|||
| // Global identifier, uniquely corresponding to the chat to | |||
There was a problem hiding this comment.
Please fix the documentation:
Suggested change
| // Global identifier, uniquely corresponding to the chat to | |
| // ChatInstance is a global identifier, uniquely corresponding to the chat to |
callback.go
Outdated
| // which the message with the callback button was sent. | ||
| ChatInstance string `json:"chat_instance"` | ||
|
|
||
| // Unique identifier of the game for which a URL is requested |
demget
changed the title
|
Good catch, thank you for filling the hole in our API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The telegram Bot API includes
chat_instanceandgame_short_namein its CallbackQuery object. Particularly, thegame_short_nameis currently missing in theCallbackobject of the update when a user requests a game's url from the bot and it's also not deserialized in theGameobject of the callback's message.I think it might be nice to have the Callback struct conforming with Telegram's CallbackQuery object and also a lot easier to implement than somehow populating the Game struct in the message.