Support CMAKE_GENERATOR='Ninja'

[mryzhov]

If the environment variable CMAKE_GENERATOR='Ninja' is set, the build will switch to Ninja. However, py-build-cmake adds CMAKE_GENERATOR_PLATFORM ('-A', 'x64') to the configuration string, which causes it to fail:

subprocess.CalledProcessError: Command '['cmake', '-S', 'C:\Users\dev\src\openvino_tokenizers_public', '-B', 'C:\Users\dev\src\openvino_tokenizers_public\.py-build-cmake_cache\py3-none-win_amd64', '-A', 'x64', '-C', 'C:\Users\dev\src\openvino_tokenizers_public\.py-build-cmake_cache\py3-none-win_amd64\py-build-cmake-preload.cmake', '-D', 'OPENVINO_TOKENIZERS_INSTALL_BINDIR=openvino_tokenizers/lib', '-D', 'OPENVINO_TOKENIZERS_INSTALL_LIBDIR=openvino_tokenizers/lib', '-D', 'CMAKE_BUILD_TYPE:STRING=Release']' returned non-zero exit status 1.

-- Building for: Ninja
CMake Error at CMakeLists.txt:40 (project):
Generator

  Ninja

does not support platform specification, but platform

  x64

was specified.

[tttapa]

Hi, thanks for the report!

The recommended way to change the CMake generator is to use the cmake.generator configuration option. You can override it on the command line using, for example:

python -m build -C override=windows.cmake.generator=Ninja

That said, I'm currently experimenting with support for CMAKE_GENERATOR as a fall-back, if no cmake.generator is specified in the config.

[mryzhov]

Thank you for the answer. Yes, I’ve also specified the generator directly in the build command—it helps.

python -m pip wheel --config-settings=override=cmake.generator='Ninja'

[mryzhov]

tested the new version (0.4.3) in openvinotoolkit/openvino_tokenizers#464, it works, thanks a lot for the quick fix!