refactor: remove TskitTypeAccess trait #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trait has been replaced with pub fns for all types. The trait was not a great idea as it made no sense to be generic over access to the low-level pointers. BREAKING CHANGE: removed a pub trait.
molpopgen
force-pushed
the
remove_non_traits
branch
from
c22e22c to
8313ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trait has been replaced with pub fns for all types.
The trait was not a great idea as it made no sense
to be generic over access to the low-level pointers.
BREAKING CHANGE: removed a pub trait.