feat: enhance post-annotations to support both workflow_run and same-workflow scenarios #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workflow scenarios - Add dual download strategy using actions/download-artifact for same-workflow scenarios - Fallback to GitHub API for workflow_run events (fork PRs) - Support github.run_id in addition to github.event.workflow_run.id - Handle commit SHA for both fork PR and regular PR scenarios - Preserve backward compatibility for existing fork PR workflows This allows post-annotations to work for: 1. Fork PRs using workflow_run trigger (existing functionality) 2. Regular PRs with split jobs in same workflow (new functionality) 3. Regular PRs with direct posting (existing functionality)
|
@TylerJang27 would it be possible to get the required approval to run checks on this PR branch? |
|
CC @puzzler7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
post-annotationsfunctionality to work in both workflow_run scenarios (fork PRs) and same-workflow scenarios (regular PRs with split jobs).Changes
actions/download-artifact@v4for same-workflow scenariosgithub.event.workflow_run.idandgithub.run_idUse Cases
This enhancement supports three scenarios:
Fork PRs (existing functionality preserved):
workflow_rundownloads and posts themRegular PRs with split jobs (new functionality):
save-annotations: truepost-annotations: trueto download and post annotations from same workflowRegular PRs (existing direct posting still works):
Testing
The changes maintain backward compatibility while adding new capabilities. The fallback mechanism ensures that if one approach fails, the other is attempted.
Related Issues
Addresses the limitation where
post-annotationsonly worked with workflow_run events, now enabling its use in regular branch PRs with split-job configurations.