Add metrics to SaneHTTPClient #4471
Conversation
1. Increment counter for URL 2. Time the latency 3. Increment counter for non-200 calls Added Tests
| // Limit path length to avoid extremely long paths creating high cardinality | ||
| if len(sanitized.Path) > 100 { | ||
| sanitized.Path = sanitized.Path[:100] + "..." | ||
| } |
There was a problem hiding this comment.
Need suggestions, if we need to do this trimming or not
There was a problem hiding this comment.
👍🏻 I think this is good. ...Pretty sure other metrics systems do this by default too (though it's been a while since I used like, Datadog)
| prometheus.CounterOpts{ | ||
| Namespace: MetricsNamespace, | ||
| Subsystem: "http_client", | ||
| Name: "requests_total", |
There was a problem hiding this comment.
Let's prefix all these w/ http_
There was a problem hiding this comment.
Or, if Subsystem up there already namespaces it, then this is fine 👌🏻 (I am not a prometheus expert haha)
There was a problem hiding this comment.
Namespace, Subsystem, and Name are components of the fully-qualified
As per this doc, subsystem is already prefixing the metric. So I guess the metric title would look something like trufflehog_http_client_requests_total
| // Limit path length to avoid extremely long paths creating high cardinality | ||
| if len(sanitized.Path) > 100 { | ||
| sanitized.Path = sanitized.Path[:100] + "..." | ||
| } |
There was a problem hiding this comment.
👍🏻 I think this is good. ...Pretty sure other metrics systems do this by default too (though it's been a while since I used like, Datadog)
Note: Claude code helped me in writing tests.
Checklist:
make test-community)?make lintthis requires golangci-lint)?