Update notion api rule to take new key version #4318
Conversation
There was a problem hiding this comment.
Hey @Tapiocaba, thanks for opening this PR to update the regex pattern for the Notion detector based on the recent token format changes, really appreciate your contribution!
That said, we won't be able to merge this as-is since the old secret format is still valid and in use. Instead of modifying the existing detector, it would be better to create a v2 of the Notion detector. This way, we can support detection of both the old and new token formats without losing compatibility.
If you'd like to help with creating the new version, feel free to check out our guide on building a v2 detector. I am happy to assist if you have any questions.
Thanks again for bringing this to our attention!
| @@ -22,13 +22,13 @@ var ( | |||
| client = common.SaneHttpClient() | |||
|
|
|||
| // Make sure that your group is surrounded in boundary characters such as below to reduce false positives. | |||
| keyPat = regexp.MustCompile(`\b(secret_[A-Za-z0-9]{43})\b`) | |||
| keyPat = regexp.MustCompile(`\b((?:secret_[A-Za-z0-9]{43})|ntn_[0-9]{11}[A-Za-z0-9]{32}[A-Za-z0-9]{3})\b`) | |||
There was a problem hiding this comment.
Great 😃 Could you move the new pattern to a separate V2 detector instead of merging it into the existing one? Since the API for verification is the same, we can extract the verification logic into a shared method and use it in both versions.
Description:
This commit adds the updated (
ntn_prefix) Notion API regex key detection and updates the test keys.secretprefix keys have been depreciated in the public api.Checklist:
make test-community)?make lintthis requires golangci-lint)?