admin: sync internal bugfixes and enhancements #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squash merge branch 'admin_serve_err' into 'master' admin: ignore normal listener close error TAPD: --story=885733287 (cherry picked from commit 122011ff16e78a56140966006ca97af7c5e53c01)
Squash merge branch 'admin_serve_log' into 'master' admin: log when admin server starts http://mk.woa.com/q/290306/answer/113294 TAPD: --story=886789359 (cherry picked from commit 2a75e6709755105d51a8e45a941e00846b0f60ba)
Squash merge branch 'admin_test1' into 'master' This MR modifies admin/admin_test.go: error should be checked first. TAPD: --story=117595419 (cherry picked from commit e6de08de95f57fcd3016cd9c30d075350954d8f6)
…quest !2489) Squash merge branch 'admin-pprof' into 'master' close #912 TAPD: --story=116151335 (cherry picked from commit c4e0403f06b0e4b5f71e5f1204af056e39d5d90f) # Conflicts: # admin/README.md # admin/README.zh_CN.md # admin/admin.go # admin/admin_test.go # admin/mux.go # go.mod # go.sum
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
===================================================
+ Coverage 85.92031% 86.08014% +0.15982%
===================================================
Files 190 189 -1
Lines 16364 16322 -42
===================================================
- Hits 14060 14050 -10
+ Misses 1739 1714 -25
+ Partials 565 558 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandyskies
approved these changes
Sep 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.