feat: add metadata to TaskHandler interface #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
hyprh
approved these changes
Jul 28, 2025
|
@hyprh looks like the PR is failing on the |
Rememorio
reviewed
Jul 28, 2025
| @@ -72,6 +72,9 @@ type TaskHandler interface { | |||
|
|
|||
| // GetContextID returns the context ID of the current message, if any. | |||
| GetContextID() string | |||
|
|
|||
| // GetMetadata returns the metadata of the current task. | |||
| GetMetadata() (map[string]interface{}, error) | |||
There was a problem hiding this comment.
What about adopting a uniform style and replace interface{} with any? Since you had used metadata map[string]any below.
There was a problem hiding this comment.
Sorry, I did not noticed this comment and merged it , I will fix it.
| // GetMetadata returns the metadata of the current request. | ||
| func (h *memoryTaskHandler) GetMetadata() (map[string]interface{}, error) { | ||
| if h.metadata == nil { | ||
| return nil, fmt.Errorf("metadata is nil") |
There was a problem hiding this comment.
errors.New("metadata is nil") might be better
| // GetMetadata returns the metadata of the current request. | ||
| func (h *taskHandler) GetMetadata() (map[string]interface{}, error) { | ||
| if h.metadata == nil { | ||
| return nil, fmt.Errorf("metadata is nil") |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To retrieve metadata from incoming requests further in our handlers, we need to be able to set and retrieve it on the handler itself. This introduces an optional field called metadata, and a new method named GetMetadata().
Fixes #67
RELEASE NOTES: Allows retrieval of metadata from client requests throughout the handler lifecycle.