-
Notifications
You must be signed in to change notification settings - Fork 34
Fix JSON Marshal for StreamingMessageEvent #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2. using value marshal
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
The test failed... but i have no idea how to fix it |
Hi, you could try keep the pointer receiver of unmarshal, I think it should be work. func (r *StreamingMessageEvent) UnmarshalJSON(data []byte) error { -> func (r StreamingMessageEvent) UnmarshalJSON(data []byte) error { |
The test failed because of the |
I think a temporary solution is add Event interface to TaskEvent, and handle TaskEvent in sendSSEEvent manually. We will try to remove StreamingTask and TaskEvent in further version. ![]() ![]() |
Would you mind submitting this modification for us? Or let's get this CR approved first and then we fix it later. |
OK, please merge this. |
status_update
should bestatus-update
final
args is missing inNewTaskStatusUpdateEvent
MarshalJSON
is using a pointer receiver, while will casue this function not be called. The SSE json data is wrong(the right screenshot):