[Backend] Move shared memory address space to target info
#7909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgreving2304
requested review from
antiagainst,
zhanglx13 and
ptillet
as code owners
hgreving2304
force-pushed
the
user/hgreving/smem_targetinfo
branch
from
ab94b50 to
44a3100
Compare
ThomasRaoux
reviewed
Aug 20, 2025
| @@ -740,7 +740,13 @@ static FailureOr<SmallVector<Value>> lowerTMemLdStFromTypes( | |||
|
|
|||
| struct TensorMemoryLoadOpConversion | |||
| : public ConvertOpToLLVMPattern<triton::nvidia_gpu::TMEMLoadOp> { | |||
| using ConvertOpToLLVMPattern::ConvertOpToLLVMPattern; | |||
|
|
|||
| explicit TensorMemoryLoadOpConversion(LLVMTypeConverter &typeConverter, | |||
There was a problem hiding this comment.
do we need to pass the target info for the files that are nvidia specific?
There was a problem hiding this comment.
We don't need as far as downstream is concerned, but it'll make it more consistent and have only one place where "3" is spelled out. If you don't want that, I can revert these parts
hgreving2304
force-pushed
the
user/hgreving/smem_targetinfo
branch
from
44a3100 to
ed1e0b4
Compare
In order to modularize downstream backends.
hgreving2304
force-pushed
the
user/hgreving/smem_targetinfo
branch
from
ed1e0b4 to
d286e54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to modularize downstream backends.