Add rbmsg back to TRILOGY_ERR #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also curious if these lines in trilogy/contrib/ruby/ext/trilogy-ruby/cext.c Lines 376 to 381 in 004d02a While there is no |
This was previously [removed][1] when error classes were refactored, but it doesn't seem to have been done so intentionally. When debugging a previous [fix][2], this missing context would have helped narrow down the problem initially as the rbmsg includes where the error was originating. [1]: f9ee855 [2]: cb788be
skipkayhil
force-pushed
the
hm-restore-error-context
branch
from
e9a5d6a to
25aa20b
Compare
adrianna-chang-shopify
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Thanks, yeah don't think we intended to remove this! 😅
I'm also curious if these lines in auth_switch should be changed to trilogy_auth_switch_recv
I think we should still reference the call that failed, but maybe we could add more context to the message, like trilogy_auth_recv on authenticate vs trilogy_auth_recv on auth_switch?
adrianna-chang-shopify
merged commit e84501b
into
trilogy-libraries:main
11 checks passed
bquorning
added a commit
to zendesk/active_record_host_pool
that referenced
this pull request
Dec 9, 2024
A Trilogy error message needed adjusting, see trilogy-libraries/trilogy#187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously removed when error classes were refactored, but it doesn't seem to have been done so intentionally.
When debugging a previous fix, this missing context would have helped narrow down the problem initially as the rbmsg includes where the error was originating.