Skip to content

Conversation

brian-pane
Copy link

No description provided.

Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
fuzz-compress ?
fuzz-decompress ?
test-aarch64-apple-darwin 87.26% <ø> (-2.38%) ⬇️
test-x86_64-apple-darwin 85.55% <ø> (-2.18%) ⬇️
test-x86_64-unknown-linux-gnu 87.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libz-rs-sys/src/gz.rs 89.24% <ø> (-4.89%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brian-pane
Copy link
Author

Separate from this PR, the code coverage report shows gaps that I can't figure out. For example, here it shows that gzclose_r isn't invoked with a null argument, but that happens here in the test cases.

@folkertdev
Copy link
Collaborator

You can run cargo llvm-cov locally on just the test-libz-rs-sys I to hlget more accurate coverage I believe.

Also we're at rustweek this week, so I'll probably only get to reviewing this next week

@folkertdev folkertdev merged commit e4448e7 into trifectatechfoundation:main May 18, 2025
24 checks passed
@brian-pane brian-pane deleted the gz-test-coverage branch May 27, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants