Skip to content

Implement gzseek for reads, as well as gzrewind #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

brian-pane
Copy link

No description provided.

Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 80.70175% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
libz-rs-sys/src/gz.rs 80.70% 22 Missing ⚠️
Flag Coverage Δ
fuzz-compress ?
fuzz-decompress ?
test-aarch64-apple-darwin 87.47% <79.82%> (-1.02%) ⬇️
test-x86_64-apple-darwin 85.76% <80.70%> (-0.14%) ⬇️
test-x86_64-unknown-linux-gnu 87.00% <16.66%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libz-rs-sys/src/gz.rs 89.73% <80.70%> (-2.56%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brian-pane brian-pane force-pushed the gzseek branch 3 times, most recently from 7fa0e62 to f051e28 Compare May 2, 2025 23:19
@brian-pane
Copy link
Author

The remaining test error is because I'm checking for expected character sequences at specific offsets in a text file included in the project. Git in the Windows CI environment translates newlines to CRLF when it checks out that file. I'll need to rework the test case to use one of the binary test-data files instead.

@brian-pane brian-pane marked this pull request as draft May 2, 2025 23:29
@brian-pane brian-pane marked this pull request as ready for review May 3, 2025 16:52
@brian-pane
Copy link
Author

I only included the read paths for gzseek because this PR is kind of big already. I'm planning to add the write support as a separate PR in the future.

@folkertdev folkertdev merged commit ff267d0 into trifectatechfoundation:main May 3, 2025
24 checks passed
@brian-pane brian-pane deleted the gzseek branch May 3, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants