Implement gzputc and gzputs #351
Conversation
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
There are a couple of test coverage gaps that I want to fix, and then I'll move this PR out of draft state. |
libz-rs-sys/src/gz.rs
Outdated
| if unsafe { gz_write(state, buf.as_ptr().cast::<c_void>(), 1) } != 1 { | ||
| return -1; | ||
| } | ||
| c & 0xff |
There was a problem hiding this comment.
| if unsafe { gz_write(state, buf.as_ptr().cast::<c_void>(), 1) } != 1 { | |
| return -1; | |
| } | |
| c & 0xff | |
| match unsafe { gz_write(state, buf.as_ptr().cast::<c_void>(), 1) } { | |
| 1 => c & 0xff, | |
| _ => -1, | |
| } |
libz-rs-sys/src/gz.rs
Outdated
| if put < len as _ { | ||
| -1 | ||
| } else { | ||
| len as _ | ||
| } |
There was a problem hiding this comment.
| if put < len as _ { | |
| -1 | |
| } else { | |
| len as _ | |
| } | |
| match put.cmp(&len) { | |
| Ordering::Less => -1, | |
| Ordering::Equal | Ordering::Greater => len as _, | |
| } |
libz-rs-sys/src/gz.rs
Outdated
| unsafe { | ||
| gz_error( | ||
| state, | ||
| Some((Z_STREAM_ERROR, "string length does not fit in int")), |
There was a problem hiding this comment.
using let msg = "..." should reduce the linecount here
libz-rs-sys/src/gz.rs
Outdated
| let have = unsafe { | ||
| state | ||
| .stream | ||
| .next_in | ||
| .add(state.stream.avail_in as usize) | ||
| .offset_from(state.input) | ||
| } as usize; |
There was a problem hiding this comment.
We already have this bit of code somewhere else right? Maybe this can be a method on state?
There was a problem hiding this comment.
I just pushed an update where this is encapsulated in a function. I made a small change to gz_write to simplify the safety conditions for this function. Let me know if the safety comments make sense.
No description provided.