Fix unsafe_op_in_unsafe_fn warning in AArch64 CRC32 implementation #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-pane
force-pushed
the
crc32
branch
2 times, most recently
from
4f11cf8 to
767a798
Compare
|
Did the CI recently upgrade to a newer version of Clippy? There was a lint error on some existing code, but I included a fix for it. |
folkertdev
reviewed
Apr 6, 2025
zlib-rs/src/crc32/acle.rs
Outdated
Comment on lines
13
to
14
| // SAFETY: `remainder` verifies that `before` contains enough bytes before dereferencing | ||
| c = unsafe { remainder(c, before) }; |
There was a problem hiding this comment.
that is not what the usafety of remainder is about. The function is unsafe only because it uses a target feature, and at least for our minimum supported rust version, that implies that the function must be unsafe. In this caller we also enable/assume the crc target feature, and so there are no other preconditions to satisfy.
folkertdev
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.