Skip to content

use safe chunking in wasm32/aarch64 compare256 #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2025
Merged

use safe chunking in wasm32/aarch64 compare256 #312

merged 2 commits into from
Mar 3, 2025

Conversation

folkertdev
Copy link
Collaborator

just copying the changes from the avx2 version

identical assembly is produces

@folkertdev folkertdev requested a review from bjorn3 March 3, 2025 15:45
@codecov Codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
zlib-rs/src/deflate/compare256.rs 98.06% <100.00%> (ø)

... and 1 file with indirect coverage changes

@folkertdev folkertdev merged commit 324dee9 into main Mar 3, 2025
20 checks passed
@folkertdev folkertdev deleted the wasm-compare256-safer branch March 3, 2025 16:01
@BrewTestBot BrewTestBot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@folkertdev @bjorn3