-
Notifications
You must be signed in to change notification settings - Fork 789
feat(CRDs): add gatewayAPI experimental channel option #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks @discostur for this PR. You'll need to update this CI check accordingly, and also ensure version are consistent (ie: versions are the same between experimental and standard) Would you please also update to Gateway API v1.3.0 ? |
@mloiseleur version is updated to v1.3.0; i'm not sure if i understand it right but i updates the consistency script to support the check between standard and experimental CRDs (in both charts, traefik and traefik-crd). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some tests? Otherwise looks mostly good to me
apply recommendations Co-authored-by: Babi Soraggi <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes! Just minor fixes now
Co-authored-by: Babi Soraggi <[email protected]>
@bpsoraggi fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution
Overall, the PR LGTM. I have concerns about the values. Unless I missed something, I understand that with this implementation, user can enable both standard and experimental channel. When there is a breaking change in experimental channel, it may lead to severe consequences. @discostur Would you please update the PR to avoid that ? I see two options:
|
What does this PR do?
gatewayAPIExperimentalChannel
Motivation