Skip to content

feat(CRDs): add gatewayAPI experimental channel option #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

discostur
Copy link

@discostur discostur commented Jul 24, 2025

What does this PR do?

  • adds the ability to install gatewayAPIExperimentalChannel
  • you can switch whether you want to install standard or experimental channel
  • i added the gateway api release v1.2.1 (like standard channel); might be updated soon because 1.3.0 should be supported with traefik 3.5.0

Motivation

@mloiseleur mloiseleur requested a review from darkweaver87 July 28, 2025 14:08
@mloiseleur
Copy link
Member

Thanks @discostur for this PR.
We have a consistency check between CRDs of regular Chart and CRDs of this additional Chart.

You'll need to update this CI check accordingly, and also ensure version are consistent (ie: versions are the same between experimental and standard)

Would you please also update to Gateway API v1.3.0 ?

@mloiseleur mloiseleur changed the title add gatewayAPIExperimental feat(CRDs): add gatewayAPI experimental channel option Jul 28, 2025
@discostur
Copy link
Author

@mloiseleur version is updated to v1.3.0; i'm not sure if i understand it right but i updates the consistency script to support the check between standard and experimental CRDs (in both charts, traefik and traefik-crd).

Copy link
Contributor

@bpsoraggi bpsoraggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some tests? Otherwise looks mostly good to me

@discostur
Copy link
Author

@bpsoraggi

  • thanks for your suggestions, all accepted
  • tests added
  • fixed the if condition that experimental wins over standard if both are active

Copy link
Contributor

@bpsoraggi bpsoraggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! Just minor fixes now

@discostur
Copy link
Author

@bpsoraggi fixed

Copy link
Contributor

@bpsoraggi bpsoraggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution

@mloiseleur
Copy link
Member

mloiseleur commented Aug 8, 2025

Overall, the PR LGTM. I have concerns about the values.

Unless I missed something, I understand that with this implementation, user can enable both standard and experimental channel. When there is a breaking change in experimental channel, it may lead to severe consequences.

@discostur Would you please update the PR to avoid that ? I see two options:

  1. Turn gatewayAPI setttings into a list of two options (standard and experimental)
  2. Add requirements (like those on traefik config) on values to fail gracefully before it's applied when user enable both channels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRD] Support Gateway API Experimental CRDs TCPRoute CRD missing on clean install
3 participants