Return 0 content length for range requests for empty files #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Also came up here: seanmonstar/reqwest#1559 (comment)
Currently tower-http's
ServeDir
handles range requests for empty files slightly incorrectly, it returns a correctly emptyContent-Range
but theContent-Length
is set to1
. Which causes troubles inreqwest
(it tries to read 1 byte which never comes).For example:
Solution
For empty files, return a content length of 1, instead of calculating it from the inclusive range.