-
Notifications
You must be signed in to change notification settings - Fork 203
normalize_path: Add Append
mode
#547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I tried to just solve the #530 in this PR. But I think we can improve this further. Currently merging slashes are happening implicitly which I think should be explicit. I can also refactor this and split the code for different modes. |
As for the naming, I added a |
@jplatte Can you check this out? I understand you might be busy, just tagging in case you missed it. |
I saw, just busy. Feel free to ping me again in a week or two if I haven't responded then. |
@jplatte Got some time to review this? |
Re-triggering CI... |
oops, missclick on review :( |
No worries. |
Now it's ready |
Closes #530