Skip to content

normalize_path: Add Append mode #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 18, 2025
Merged

normalize_path: Add Append mode #547

merged 7 commits into from
May 18, 2025

Conversation

daalfox
Copy link
Contributor

@daalfox daalfox commented Mar 1, 2025

Closes #530

@daalfox
Copy link
Contributor Author

daalfox commented Mar 1, 2025

I tried to just solve the #530 in this PR. But I think we can improve this further. Currently merging slashes are happening implicitly which I think should be explicit. I can also refactor this and split the code for different modes.

@daalfox
Copy link
Contributor Author

daalfox commented Mar 1, 2025

As for the naming, I added a new function that takes mode but maybe we want to add some convenience functions. I suggest normalize_trim and normalize_append or just trim and append because we know it's an http specific service already. Maybe merge_slashes, merge_trim, merge_append in future?

@daalfox daalfox marked this pull request as ready for review March 2, 2025 09:44
@daalfox
Copy link
Contributor Author

daalfox commented Mar 3, 2025

@jplatte Can you check this out? I understand you might be busy, just tagging in case you missed it.

@jplatte
Copy link
Member

jplatte commented Mar 3, 2025

I saw, just busy. Feel free to ping me again in a week or two if I haven't responded then.

@daalfox
Copy link
Contributor Author

daalfox commented Mar 16, 2025

@jplatte Got some time to review this?

@jplatte
Copy link
Member

jplatte commented May 16, 2025

Re-triggering CI...

@jplatte jplatte closed this May 16, 2025
@jplatte jplatte reopened this May 16, 2025
@daalfox daalfox requested a review from jplatte May 18, 2025 07:21
@daalfox
Copy link
Contributor Author

daalfox commented May 18, 2025

oops, missclick on review :(

@jplatte
Copy link
Member

jplatte commented May 18, 2025

No worries.

@daalfox
Copy link
Contributor Author

daalfox commented May 18, 2025

Now it's ready

@daalfox daalfox requested a review from jplatte May 18, 2025 08:20
@jplatte jplatte enabled auto-merge (squash) May 18, 2025 16:18
@jplatte jplatte merged commit 86615aa into tower-rs:main May 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make normalize_path configurable to allow for trailing slashes
2 participants