`compat/isSafeInteger` doesn't actually narrow the type

[GingerAdonis]

The documentation on isSafeInteger states: "This function can also serve as a type predicate in TypeScript, narrowing the type of the argument to number.". But it actually doesn't do that, as the native Number.isSafeInteger doesn't do that either.

It would be great if it actually would narrow the type. Same goes for functions like isFinite.

[raon0211]

Yes, it seems that isSafeInteger should return value is number (type predicate). I think this is a bug.

[Yeom-JinHo]

@GingerAdonis
I’ve addressed this in #1510
When you have some time, please take a look and share your feedback. 😊

[GingerAdonis]

@GingerAdonis
I’ve addressed this in #1510
When you have some time, please take a look and share your feedback. 😊
Looks good to me. Thank yoh.

Should we apply type narrowing to isFinite as well? It's a similar function and also returns false for anything that's not a number type (and Infinity, etc. of course).

[Yeom-JinHo]

@GingerAdonis
I’ve addressed this in #1510
When you have some time, please take a look and share your feedback. 😊
Looks good to me. Thank yoh.

Should we apply type narrowing to isFinite as well? It's a similar function and also returns false for anything that's not a number type (and Infinity, etc. of course).

I think it would be good to update isFinite as well.
What do you think, @raon0211 and @GingerAdonis ?

[Yeom-JinHo]

@GingerAdonis @raon0211
I’ve applied type narrowing to isFinite(#1511 ), similar to the recent isSafeInteger(#1510) update.
Please take a look and let me know what you think.