Fixing Admin Privalge Bug #9
Open
+17
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this PR! |
|
Oof thanks also for bumping this... I'll review today and merge Sorry about the delay, in the future feel free to ping me more often |
torshepherd
reviewed
Apr 25, 2025
| const electronBase = isVSCodeBelowVersion("1.70.0") | ||
| ? "electron-browser" | ||
| : "electron-sandbox"; | ||
| const workBenchFilename = | ||
| vscode.version == "1.94.0" ? "workbench.esm.html" : "workbench.html"; |
There was a problem hiding this comment.
Does this logic need to be updated since the PR was made? I assume we're quite a few versions after this?
Can you change this to use <= instead of equality?
There was a problem hiding this comment.
@BishoPower FYI ^^ if you change this I'll merge the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.