Clean media files between test runs #263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix relative path from project root in clean
Add tox to testing dependency bundle
Remove test-media before each tox env run
zerolab
reviewed
Aug 19, 2025
tox.ini
Outdated
| commands_pre = | ||
| python -I {toxinidir}/tests/manage.py migrate | ||
| commands = | ||
| -rm -rf tests/testapp/test-media |
There was a problem hiding this comment.
Sorry, but this is not an acceptable way. adding rm to allowed externals opens up the door for potential abuse.
The solution should be entirely TestCase-bound. That is, clear the test uploaded media directory on tearDown. e.g.
or
There was a problem hiding this comment.
Oh OK, thanks for the feedback -- I'll change it to do it in tearDown
There was a problem hiding this comment.
Actually, I noticed in
that there was already an attempt to clean test media. The problem is that it didn't do anything since the test app used a different MEDIA_ROOT.
So I changed the test app settings to use the same MEDIA_ROOT. Would this be acceptable?
make clean only removes .tox and __pycache__
Do not allow rm external command
Use MEDIA_ROOT and STATIC_ROOT from wagtail.tests.settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cleaning the media files from
tests/testapp/test-mediabetween each tox env run. It actually does so before each run (if a user wants to inspect the created files after a test run).Alternatively, the files could be removed after test runs, leaving it all clean.
Additionnally, it adds tox to the optional testing dependency bundle so that when users initially runs
pip install -e .[testing], they are ready to go.Lastly, it fixes the relative path in the
make cleanrecipe of themakefile.