This repository was archived by the owner on Jan 4, 2020. It is now read-only.
优化 get_client_ip 函数的adv模式的处理 #434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchu
commented
May 31, 2016
zhangchu
commented
- 之前的代码在对 HTTP_X_FORWARDED_FOR 内容进行 array_search 和 unset 操作是没有意义的。
- 最重要的是，在一些网络架构下，HTTP_X_FORWARDED_FOR 开始部分中会包含一些内网地址，这些地址对于get_client_ip的逻辑是无用的。
- 为此增加了两个函数，is_inner_ip和get_first_outerip
1. 之前的代码在对 HTTP_X_FORWARDED_FOR 内容进行 array_search 和 unset 操作是没有意义的。 2. 最重要的是，在一些网络架构下，HTTP_X_FORWARDED_FOR 开始部分中会包含一些内网地址，这些地址对于get_client_ip的逻辑是无用的。 3. 为此增加了两个函数，is_inner_ip和get_first_outerip
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.