Skip to content

Conversation

epage
Copy link
Member

@epage epage commented Oct 9, 2025

This is an attempt to better match serde

This is still missing

  • f32
  • f64
  • newtype
  • Some

Fixes #1049
Fixes #626

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@coveralls
Copy link

coveralls commented Oct 9, 2025

Pull Request Test Coverage Report for Build 18387038581

Details

  • 56 of 182 (30.77%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 69.861%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/toml_edit/src/ser/key.rs 4 24 16.67%
crates/toml/src/de/deserializer/key.rs 9 36 25.0%
crates/toml/src/ser/value/key.rs 11 38 28.95%
crates/toml_edit/src/de/key.rs 8 60 13.33%
Totals Coverage Status
Change from base Build 18166737602: -0.4%
Covered Lines: 6808
Relevant Lines: 9745

💛 - Coveralls

@epage epage force-pushed the key branch 2 times, most recently from bc43f1e to ac1e077 Compare October 9, 2025 19:34
@epage epage merged commit 1b579c3 into toml-rs:main Oct 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Deserialize number keys as integer types support char as map key

2 participants