spawn_with_attributes for Command on

[heaths]

Is your feature request related to a problem? Please describe.

To have a process write to a pseudoterminal (pty) on Windows, you need to adjust its thread proc attributes. There's currently no way to do this with tokio::process::Command.

Describe the solution you'd like

It would be great if tokio added support on Windows like the nightly CommandExt::spawn_with_attributes. I'd be happy to submit a PR.

Describe alternatives you've considered

I'm using std currently and reading in a spawned task not only is this the only place I'm using std::process::Command instead of tokio's, but without all your async plumbing I'm having trouble waiting for a BufReader to finish after the process terminates. This already works correctly with tokio.

[Darksonn]

There is currently no mechanism to let Tokio to access unstable features in std. Not even --cfg tokio_unstable allows that. We cannot support this at this time.

[PaulDance]

We're finding ourselves in the same situation. The solution I've found is to add an API that enables customizing how the spawn is performed as it is now at that place that the attributes are set. The required changes are relatively minimal and avoid any dependency on nightly Rust, but could be considered a bit too vague for such a niche use case. Would that still seem acceptable? I'll open a PR up proposing this.

[heaths]

@PaulDance I was initially considering that myself as well, that we don't need to depend on changes in std but just effectively copy them to tokio but got the impression - especially after digging into the tokio::process::Command source after the previous comment - using std::process::Command as much as possible is desired. But, really, adding Windows-only attribute support to spawn is pretty straight forward. I'm a little surprised it hasn't stabilized in std already.