Add unix stream & listener #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-chuang
commented
Feb 27, 2022
Contributor
Author
|
Ready for review |
jon-chuang
force-pushed
the
unix
branch
2 times, most recently
from
8ecc6a7 to
98ab4b2
Compare
Noah-Kennedy
reviewed
Mar 1, 2022
Noah-Kennedy
reviewed
Mar 1, 2022
Noah-Kennedy
reviewed
Mar 1, 2022
Noah-Kennedy
reviewed
Mar 1, 2022
Contributor
|
This is almost there, just a couple more changes are needed. |
Noah-Kennedy
requested changes
Mar 1, 2022
Contributor
Noah-Kennedy
left a comment
Noah-Kennedy
left a comment
There was a problem hiding this comment.
I left some feedback comments for what needs addressed.
Noah-Kennedy
approved these changes
Mar 1, 2022
Contributor
Noah-Kennedy
left a comment
Noah-Kennedy
left a comment
There was a problem hiding this comment.
Looks good, thanks for doing this!
Contributor
|
@jon-chuang run |
Contributor
Author
|
The gods are appeased :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Future:
Comments:
ToSocketAddress. Personally, I like the use better, and also it is more consistent with tokio API. So I'm proposing to keep this change.