Skip to content

Conversation

@ollie-etl
Copy link
Contributor

Box msghdr in SendMsgZc struct to ensure it is stable through the lifetime of the op.

This is required to ensure the msghdr is stable over the lifetime of the
operation
@ollie-etl ollie-etl force-pushed the bug-unstable-msghdr branch from 61f8f76 to 52b29de Compare March 20, 2023 19:56
@ollie-etl
Copy link
Contributor Author

@Noah-Kennedy this should be uncontentious

@Icelk
Copy link
Contributor

Icelk commented Mar 28, 2023

@ollie-etl Have you managed to pass a msg_control larger than 15 bytes?

Copy link
Collaborator

@FrankReh FrankReh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@FrankReh FrankReh enabled auto-merge (squash) March 29, 2023 13:47
@FrankReh FrankReh disabled auto-merge March 29, 2023 13:47
@ollie-etl
Copy link
Contributor Author

@Icelk I haven't tried. My interest in these is the vectored send / recv they provide.

@FrankReh FrankReh merged commit 4fd3197 into tokio-rs:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants