Make msghdr.msg_name optional

[redbaron]

sendmsg can be used on connected sockets without msg_name.

[FrankReh]

These changes may be a step in the right direction but they are not complete. The branch doesn't compile.

Please run cargo build and cargo test on your branch before starting a PR. Also cargo fmt and cargo clippy. All with the most recent compiler. In this case, you can make additional commits to your branch. See all those commands pass and then push up to GitHub again.

Here, even the file src/io/sendmsg_zc.rs which you changed won't compile, let along the entire library not compiling.

And while your comment about sendmsg is correct, please include a link to an online manpage from some place like arch linux so anyone reading through this can be starting with the same understanding.

Thank you.

Edit: Perhaps your point was just to highlight a shortcoming in the API but did not want to offer a solution - I've sometimes done that in other repos. Then just opening an Issue would be a better vehicle.

[redbaron]

I am really sorry for incomplete PR, IDK how it happened. Pushed fixed version.

[FrankReh]

Looking good. Just asking for some small changes, all in net/udp.rs I think.

[FrankReh]

Thank you!

[redbaron]

Thank you!

I didn't realise you'd merge it straight away, my intention was to get approval then squash all changes. sorry for many useless commits

[FrankReh]

We squash the changes for every PR in this repo. At least we mean to. There may have been some that slipped through. All the commits weren't a problem. The GitHub merge will do the squash for us if we like. I did end up pulling this branch locally to be able to look through things when there were problems. The final merge from master I didn't see needing to wait for you as it might have taken another day for the turn around. And there are a number of outstanding PRs that can get merged when another maintainer has a look so I wanted as much committed and remerged to the other PRs as quickly as possible.