Skip to content

update(api,subscriber)!: upgrade tonic to 0.13 #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2025
Merged

update(api,subscriber)!: upgrade tonic to 0.13 #615

merged 5 commits into from
Apr 1, 2025

Conversation

Sagebati
Copy link
Contributor

@Sagebati Sagebati commented Mar 28, 2025

Hi,

I tried to upgrade tonic to the last version, unlocking the upgrade my axum based web app.

But I got this

error[E0277]: the trait bound `Channel: Service<request::Request<tonic::body::Body>>` is not satisfied
   --> tokio-console/src/conn.rs:120:34
    |
120 |                 let mut client = InstrumentClient::new(channel);
    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Service<request::Request<tonic::body::Body>>` is not implemented for `Channel`
    |
    = help: the trait `Service<request::Request<tonic::body::Body>>` is not implemented for `Channel`
            but trait `Service<request::Request<http_body_util::combinators::box_body::UnsyncBoxBody<tonic::codegen::Bytes, Status>>>` is implemented for it
    = help: for that trait implementation, expected `http_body_util::combinators::box_body::UnsyncBoxBody<tonic::codegen::Bytes, Status>`, found `tonic::body::Body`
    = note: required for `Channel` to implement `tonic::client::service::GrpcService<tonic::body::Body>`

BREAKING CHANGE:
This is a breaking change for users of console-api and
console-subscriber, as it changes the public tonic dependency
to a semver-incompatible version. This breaks compatibility with
tonic 0.12.x.

@Sagebati Sagebati requested a review from a team as a code owner March 28, 2025 14:52
@Sagebati Sagebati changed the title Update tonic to 0.13 chore: upgrade tonic to 0.13 Mar 28, 2025
@Sagebati
Copy link
Contributor Author

I missed a Cargo.toml, now it's compiling and test passed. I can squash my commit is desired.

@hds hds changed the title chore: upgrade tonic to 0.13 update(api,subscriber)!: upgrade tonic to 0.13 Mar 31, 2025
@hds
Copy link
Collaborator

hds commented Mar 31, 2025

@Sagebati Looks like there are a couple of errors, would you be able to have a look?

@Sagebati
Copy link
Contributor Author

Sagebati commented Mar 31, 2025

I added the "util" feature flag on a tower dependency, that could be it.

Copy link
Collaborator

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@hds hds merged commit 2bd1afd into tokio-rs:main Apr 1, 2025
19 checks passed
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants