axum-extra: make option_layer map body type to axum::body::Body
#3469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mladedav
changed the title
option_layer map body type to axum::body::Body
mladedav
force-pushed
the
dm/option-layer-body
branch
2 times, most recently
from
f4baeb8 to
e1ee66a
Compare
mladedav
force-pushed
the
dm/option-layer-body
branch
from
e1ee66a to
809dae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
option-layerdoes not work with services that map the body type such asTrace.The comment there also seems to be obsolete as
tower::util::option_layerno longer maps the error types.Solution
Now the body will be converted back right away. This will be what most users will most likely want to have happened though there may be advanced scenarios, where someone might want to map the body with another layer and then pay the price of converting to
axum::body::Bodyjust once. In that case, users can just usetower::util::option_layer.