Reject JSON bodies with trailing chars #3453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanns
approved these changes
Sep 2, 2025
jplatte
force-pushed
the
json_extra_chars
branch
from
534191d to
1a46ffa
Compare
jplatte
pushed a commit
that referenced
this pull request
Sep 28, 2025
jplatte
pushed a commit
that referenced
this pull request
Sep 28, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix for #3452
Solution
Call
deserializer.end()to ensure we reached the end of the stream. See https://docs.rs/serde_json/latest/serde_json/struct.Deserializer.html#method.end