Implement From<Bytes> for Message
#3273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifest
force-pushed
the
message-from-bytes
branch
from
bbaf52d to
ec90778
Compare
jplatte
reviewed
Mar 17, 2025
manifest
force-pushed
the
message-from-bytes
branch
from
ec90778 to
b0386b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implementation
From<Bytes>forMessageis missing.The internal representation of the binary message is
Bytes. It would be convenient to have relatedFromimplementation, especially for application code that is designed to work withBytesas opposed toVec<u8>.Solution
Added an implement
From<Bytes>forMessage.