Implement OptionalFromRequest for Multipart
#3220
Merged
+55
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcginty
force-pushed
the
optional-multipart
branch
from
f6e4fef to
19bac73
Compare
|
Thanks for this work! Do you know if there’s a timeline for merging this into master? I’m eager to upgrade to v0.8, but the lack of |
|
@fritzchr I'm not sure, I never got a response to this PR, dunno why. |
jplatte
approved these changes
May 8, 2025
|
Actually, could you add a changelog entry please? I think you may have to rebase to not cause merge conflicts w.r.t. that... If you're not familiar with that let me know and I'll do the changelog entry separately. |
|
@mcginty Do you plan to rebase anytime soon? If not you can let me know and I will rebase and do the changelog entry. |
|
Let's just do the changelog entry separately. Can you send a PR? |
|
I'll do it today in the evening @jplatte |
jplatte
pushed a commit
that referenced
this pull request
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature existed in axum 0.7, and it makes life much easier for optional multipart bodies!
I refactored the
parse_boundaryhelper function to make it easier to skip on non-multipart content types, and added a test to confirm that anOption<Multipart>behaves as expected.