Don't leak a tokio task when using serve without graceful shutdown #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
force-pushed
the
jplatte/serve-fix
branch
from
6aab90a to
82255dc
Compare
We should not spawn a tokio task to wait on a signal that can never arrive.
jplatte
force-pushed
the
jplatte/serve-fix
branch
from
82255dc to
ffea2bc
Compare
1 task
yanns
approved these changes
Apr 30, 2025
Turbo87
approved these changes
Apr 30, 2025
|
It wouldn't be that hard to write a test for graceful shutdown, I guess. For the actual fix here though - about the tokio task; I don't know how to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3112.