Skip to content

Conversation

@inkarkat
Copy link
Member

As parameter extension is active in the here-document.
Escape the literal "$" as well; not needed, but better style.

Fixes #472

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Lint your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

As parameter extension is active in the here-document.
Escape the literal "$" as well; not needed, but better style.

Fixes todotxt#472
@karbassi karbassi requested a review from Copilot October 2, 2025 01:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a documentation bug where backslashes and dollar signs in the help text for the list/ls command were not properly escaped within the here-document context. The fix ensures that literal backslashes and dollar signs are correctly displayed in the help output.

  • Escaped backslashes in regex examples to display correctly in here-document
  • Escaped dollar sign for consistent literal display
  • Fixed display of proper escape sequences for grep-style regular expressions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@karbassi karbassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

help output incorrect

2 participants