Skip to content

Conversation

@dynobo
Copy link

@dynobo dynobo commented Nov 24, 2018

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

Added feature:
New option in config file "COLOR_ID" to add highlighting for the number at the beginning of every task line (the task id),

Steps for QA:

  • Please test various combinations of highlightings with tasks containing numbers, and see if a formatting get's messed up

@dynobo
Copy link
Author

dynobo commented Nov 24, 2018

Fixes #266

@karbassi karbassi requested review from inkarkat and karbassi March 29, 2020 17:32
@karbassi
Copy link
Member

@dynobo The priority highlighting works, but the numbers do no. See below with my tests.

Screen Shot 2020-03-29 at 12 47 57 PM

Also, the test needs to have the numbers in front of the todo.txt

Copy link
Member

@karbassi karbassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dynobo see my above comment.

Copy link
Member

@inkarkat inkarkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with closing; we've already accepted a more encompassing change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants