Default to user writable directory in config #148
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user installs from a package manager ([MacPorts], [Homebrew], `yum`, etc.), the `todo.sh` script is installed into a restricted folder. This means that the result of `$(basename "$0")` is a directory where the user cannot write without elevated permissions. This generates additional noise when the user first runs `todo.sh -h`. An alternative is to default to the user's personal directory which is known to exist and will be writable by the user. [MacPorts]: https://www.macports.org [Homebrew]: http://brew.sh
inkarkat
approved these changes
Jul 20, 2021
Member
inkarkat
left a comment
inkarkat
left a comment
There was a problem hiding this comment.
Storing user data next to the application itself is a bad idea in general. I agree that defaulting to the home directory is a better default here.
wwalker
pushed a commit
to wwalker/todo.txt-cli
that referenced
this pull request
Sep 19, 2021
When a user installs from a package manager (MacPorts, Homebrew, `yum`, etc.), the `todo.sh` script is installed into a restricted folder. This means that the result of `$(basename "$0")` is a directory where the user cannot write without elevated permissions. This generates additional noise when the user first runs `todo.sh -h`. An alternative is to default to the user's personal directory which is known to exist and will be writable by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user installs from a package manager (MacPorts, Homebrew,
yum, etc.), thetodo.shscript is installed into a restrictedfolder. This means that the result of
$(basename "$0")is a directorywhere the user cannot write without elevated permissions. This
generates additional noise when the user first runs
todo.sh -h. Analternative is to default to the user's personal directory which is
known to exist and will be writable by the user.