Useless Image reload triggered at keyup event

[tim-boerner]

What is the current behavior?
If images were pasted or uploaded, so that you have img tags. Every single image is reloaded on every single keyup, which results in massive useless network traffic.

steps to reproduce
set up everything as provided in docu
use any image as inital text, e.g.: <img src=\"https://avatars2.githubusercontent.com/u/119815?s=280&v=4\"></img> or just copy and paste something
focus editing area and start typing

example at codesandbox

What is the expected behavior?
Images should not be reloaded on every keyup or change

Which versions of TinyMCE/TinyMCE-Angular, and which browser / OS are affected by this issue?
Affected versions:
TinyMCE-Angular 3.4.0 / 3.3.0 / 3.2.0
Tested with Chrome Browser and TinyMCE 5.2.0

Did this work in previous versions of TinyMCE or TinyMCE-Angular?
Seams to work with TinyMCE-Angular 3.1.0

[tim-boerner]

[SimonFc]

This only happens when you have the cache disabled, right? In any case I think this is something tinymce-angular might be able to fix

[tim-boerner]

Yes, only happens when cache is disabled

[tim-boerner]

When using the editor in inline mode and multiple editors at the same page, if also occurs when cache is enabled

[eduardhuck]

Any update on this issue? Currently breaks my application.
Currently using :
TinyMCE-Angular 3.5.2
TinyMCE 5.2.2

[eduardhuck]

@tim-boerner : Thanks for the hint regarding the 3.1.0 version. It indeed reduces the number of requests, but unfortunately not completely.

After testing the rollback, I still encountered some cases, where the image was repeatedly downloaded.

For example:

• every time you select and delete
• every time you undo or redo

[tim-boerner]

@eduardhuck : thanks for the hint as well, i didn't check that. I was only testing normal keyup.
I am still on 3.1.0. All versions above are not useable for my application.

[tim-boerner]

With version 4.1.0 the issue is not anymore on keyup events, but input events. This has been introduced by commit fd56a51

The execution of the registered onChange callback somehow triggers the image reload.

tinymce-angular/tinymce-angular-component/src/main/ts/editor/editor.component.ts

Line 174 in 6fd80c9

this.ngZone.run(() => this.onChangeCallback(editor.getContent({ format: this.outputFormat })));

[tim-boerner]

i opened #207 which could help. It is not a complete fix, but reducing the image reload effect only to cases when a custom onChange callback is registered.

[etcamol]

I am also facing the same issue in my current application at many places.
Could you please share if you have any solution approach.

[jscasca]

Thanks for the PR and thank you for your patience. This should be merged and released shortly

[jscasca]

The current fix provided by @tim-boerner was released in v4.2.2.