UUIDs: implement encoding methods, enhance testing and improve performance #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadprogram
reviewed
Mar 5, 2025
deadprogram
reviewed
Mar 5, 2025
deadprogram
reviewed
Mar 5, 2025
onshorechet
force-pushed
the
feature/uuid
branch
from
dd26313 to
a880875
Compare
…mance This changeset implements these interfaces found in the encoding package: - MarshalBinary() (data []byte, err error) - UnmarshalBinary(data []byte) error - AppendBinary(b []byte) ([]byte, error) - MarshalText() (text []byte, err error) - UnmarshalText(text []byte) error - AppendText(b []byte) ([]byte, error) ParseUUID and uuid.String are now implemented in terms of these new methods. UnmarshalText and AppendText use algorithms inspired by the hex package. Also the UUID.String method has been optimized to avoid allocations by using unsafe.String. Finally the new UnmarshalText supports 128, 32 and 16 bit uuids. Additional tests were added to verify the new methods and some existing methods missing coverage. Benchmark results (using benchstat, 10 runs each): - `ParseUUID`: ~71.04% faster (p=0.000, n=10) - `UUID.String()`: ~81.26% faster (p=0.000, n=10) - `UUID.String()`: Memory allocations reduced by 100% (48 B/op to 0 B/op)
onshorechet
force-pushed
the
feature/uuid
branch
from
a880875 to
6307294
Compare
|
Thank you very much for such a complete PR @onshorechet and for the excellent responses to my little feedback items. Great work! Now merging, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset implements these interfaces found in the encoding package:
- UnmarshalBinary(data []byte) error
- AppendBinary(b []byte) ([]byte, error)
- MarshalText() (text []byte, err error)
- UnmarshalText(text []byte) error
- AppendText(b []byte) ([]byte, error)
ParseUUID and uuid.String are now implemented in terms of these new methods. UnmarshalText and AppendText use algorithms inspired by the hex package. Also the UUID.String method has been optimized to avoid allocations by using unsafe.String. Finally the new UnmarshalText supports 128, 32 and 16 bit uuids.
Additional tests were added to verify the new methods and some existing methods missing coverage.
Benchmark results (using benchstat, 10 runs each):
-
ParseUUID: ~71.04% faster (p=0.000, n=10)-
UUID.String(): ~81.26% faster (p=0.000, n=10)-
UUID.String(): Memory allocations reduced by 100% (48 B/op to 0 B/op)