nrf528xx: add advertiser random address #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysoldak
reviewed
Jan 8, 2025
ysoldak
approved these changes
Jan 8, 2025
Contributor
ysoldak
left a comment
ysoldak
left a comment
There was a problem hiding this comment.
Looks good, but please check my comment.
Just a sanity check, you know better how it supposed to work.
Also, this PR seem to add more than it advertises in the title. Shall be fine as long as we merge with rebase to keep individual commits.
deadprogram
force-pushed
the
xudongzheng-hci-rand-addr-pr
branch
2 times, most recently
from
f2ec9bf to
1db1de6
Compare
…nInd, to leave room for FindMy data Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
…pe passed into the SoftDevice struct for API call Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
nrf528xx-advertiser-random-address
branch
from
ef7b81a to
5f464fb
Compare
Member
Author
|
@ysoldak rebased against |
Member
Author
|
Thanks for review @ysoldak now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Advertiser
SetRandomAddress()function to the nrf528xx in the same way that it was added in the PR #325 that this PR is based on.This is needed in order to implement the
FindMystyle beacons.