Skip to content

Conversation

@akuzm
Copy link
Member

@akuzm akuzm commented Sep 19, 2025

The dashes can sort differently based on collation, so the test can fail depending on the locale. Remove the dashes to fix.

The dashes can sort differently based on collation, so the test can fail
depending on the locale. Remove the dashes to fix.
@github-actions
Copy link

@kpan2034, @dbeck: please review this pull request.

Powered by pull-review

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.51%. Comparing base (f101bcb) to head (3da4799).
⚠️ Report is 143 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8650      +/-   ##
==========================================
+ Coverage   82.45%   82.51%   +0.06%     
==========================================
  Files         247      247              
  Lines       47556    47528      -28     
  Branches    12097    12093       -4     
==========================================
+ Hits        39210    39219       +9     
- Misses       3482     3500      +18     
+ Partials     4864     4809      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akuzm akuzm enabled auto-merge (squash) September 19, 2025 11:34
Copy link
Member

@dbeck dbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I was wondering, would it also work if you simply set the client collation in the SQL script?

@akuzm akuzm merged commit 1429367 into timescale:main Sep 19, 2025
43 checks passed
@akuzm akuzm deleted the collation-dash branch September 19, 2025 14:55
@akuzm
Copy link
Member Author

akuzm commented Sep 19, 2025

LGTM

I was wondering, would it also work if you simply set the client collation in the SQL script?

I think it could also work. I'm not sure how to do this properly and whether this should be done for all tests then, not individually.

@timescale-automation timescale-automation added the released-2.23.0 Released in 2.23.0 label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released-2.23.0 Released in 2.23.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants