Backport to 2.22.x: #7766: Load OSM extension in retention background worker to drop tiered chunks #8639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OSM library doesn't get loaded when a retention policy runs from a background worker. This patch ensures that the library gets loaded by calling `GetFdwRoutineByRelId()` on the OSM chunk. (cherry picked from commit c3559d4)
timescale-automation
added
the
is-auto-backport
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.22.x #8639 +/- ##
==========================================
+ Coverage 82.37% 82.46% +0.08%
==========================================
Files 248 248
Lines 47650 47624 -26
Branches 12109 12106 -3
==========================================
+ Hits 39253 39273 +20
- Misses 3507 3518 +11
+ Partials 4890 4833 -57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #7766: Load OSM extension in retention background worker to drop tiered chunks.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Load OSM extension in retention background worker to drop tiered chunks
OSM sets a special callback for dropping tiered chunks that is used by timescaledb in ts_chunk_do_drop_chunks. But in background worker OSM library doesn't get loaded and retention policy ends up not removing tiered chunks.
Disable-check: approval-count
(for some reason Gayathri's approval did not count)