Fix chunk skipping min/max calculation #8426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philkra, @fabriziomello: please review this pull request.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8426 +/- ##
==========================================
+ Coverage 82.21% 82.28% +0.07%
==========================================
Files 247 247
Lines 46828 46831 +3
Branches 11855 11861 +6
==========================================
+ Hits 38500 38537 +37
- Misses 3516 3531 +15
+ Partials 4812 4763 -49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akuzm
approved these changes
Jul 30, 2025
svenklemm
force-pushed
the
sven/chunk_skip
branch
from
99a2f6b to
a8363e9
Compare
svenklemm
force-pushed
the
sven/chunk_skip
branch
from
a8363e9 to
7880172
Compare
antekresic
approved these changes
Jul 31, 2025
svenklemm
force-pushed
the
sven/chunk_skip
branch
5 times, most recently
from
8cc058c to
180a67d
Compare
When a partially compressed chunk with segmentby column was recompressed the new min/max range would not be calculated correctly and only take the new values into account but not already compressed values.
svenklemm
force-pushed
the
sven/chunk_skip
branch
from
180a67d to
86a79d7
Compare
svenklemm
added
the
force-auto-backport
Merged
philkra
added a commit
that referenced
this pull request
Aug 5, 2025
## 2.21.2 (2025-08-05) This release contains performance improvements and bug fixes since the 2.21.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * [#8418](#8418) Fix duplicate constraints in JOIN queries * [#8426](#8426) Fix chunk skipping min/max calculation * [#8434](#8434) Allow `show_chunks` to process more than 65535 chunks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a partially compressed chunk with segmentby column was
recompressed the new min/max range would not be calculated correctly
and only take the new values into account but not already compressed
values.
Disable-check: commit-count