Skip to content

Backport to 2.20.x: #8145: Log only if compression ratio warnings enabled #8161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Backport to 2.20.x: #8145: Log only if compression ratio warnings enabled #8161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .unreleased/pr_8145
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Implements: #8145 Log only if compression ratio warnings are enabled
31 changes: 15 additions & 16 deletions tsl/src/compression/api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,22 +544,21 @@ compress_chunk_impl(Oid hypertable_relid, Oid chunk_relid)
/* Detect and emit warning if poor compression ratio is found */
float compression_ratio = ((float) before_size.total_size / after_size.total_size);
float POOR_COMPRESSION_THRESHOLD = 1.0;
ereport(ts_guc_enable_compression_ratio_warnings &&
compression_ratio < POOR_COMPRESSION_THRESHOLD ?
WARNING :
DEBUG1,
errcode(ERRCODE_WARNING),
errmsg("poor compression rate detected for chunk \"%s\"'",
get_rel_name(chunk_relid)),
errdetail("Chunk \"%s\" has a poor compression ratio: %.2f. Size before "
"compression: " INT64_FORMAT
" bytes. Size after compression: " INT64_FORMAT " bytes",
get_rel_name(chunk_relid),
compression_ratio,
before_size.total_size,
after_size.total_size),
errhint("Changing compression settings for \"%s\" can improve compression rate",
get_rel_name(hypertable_relid)));
if (ts_guc_enable_compression_ratio_warnings &&
compression_ratio < POOR_COMPRESSION_THRESHOLD)
ereport(WARNING,
errcode(ERRCODE_WARNING),
errmsg("poor compression rate detected for chunk \"%s\"'",
get_rel_name(chunk_relid)),
errdetail("Chunk \"%s\" has a poor compression ratio: %.2f. Size before "
"compression: " INT64_FORMAT
" bytes. Size after compression: " INT64_FORMAT " bytes",
get_rel_name(chunk_relid),
compression_ratio,
before_size.total_size,
after_size.total_size),
errhint("Changing compression settings for \"%s\" can improve compression rate",
get_rel_name(hypertable_relid)));
}
else
{
Expand Down
Loading