Skip to content

Fix a bug in the heartbeat agg rollup code #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

Fix a bug in the heartbeat agg rollup code #733

merged 1 commit into from
Mar 17, 2023

Conversation

WireBaron
Copy link
Contributor

This change prevents us from using the optimized path for rolling up adjacent heartbeat_aggs if the aggregates have overlapping points.

Fixes #731

@WireBaron WireBaron requested review from syvb and thatzopoulos March 10, 2023 19:37
@WireBaron
Copy link
Contributor Author

This will need a changelog entry added, but first we need to get #727 merged.

@WireBaron
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 17, 2023

Build succeeded:

@bors bors bot merged commit d73b307 into main Mar 17, 2023
@bors bors bot deleted the br/fix_hb_rollup branch March 17, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syvb syvb syvb approved these changes

+1 more reviewer

@thatzopoulos thatzopoulos thatzopoulos approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heartbeat_agg rollup gives inconsistent results.
3 participants
@WireBaron @syvb @thatzopoulos