Skip to content

Stabilizing integral and interpolated integral #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

Stabilizing integral and interpolated integral #724

merged 1 commit into from
Mar 6, 2023

Conversation

thatzopoulos
Copy link
Contributor

Fixes #719

@thatzopoulos thatzopoulos force-pushed the th/integral-stabilization branch from bea0a57 to 4257d72 Compare March 1, 2023 20:13
WireBaron
WireBaron suggested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@WireBaron WireBaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we also need an arrow accessor for the interpolated_integral. You can look at how I did this in #716 if you have any questions.

@thatzopoulos thatzopoulos force-pushed the th/integral-stabilization branch 2 times, most recently from a6b9467 to c280c50 Compare March 3, 2023 21:49
thatzopoulos
thatzopoulos commented Mar 3, 2023
View reviewed changes
extension/src/time_weighted_average.rs
None
};

// Convert from num of milliseconds to DurationUnit and then to string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section of code is a workaround for the DurationUnit enum not working with the flat_serialize macro.

@thatzopoulos thatzopoulos requested review from syvb and WireBaron March 6, 2023 16:47
@thatzopoulos thatzopoulos force-pushed the th/integral-stabilization branch from 6e3123f to d5a6bc6 Compare March 6, 2023 21:05
WireBaron
WireBaron approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@WireBaron WireBaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just address the last few comments and this is ready to merge.

extension/src/time_weighted_average/accessors.rs Outdated
start : i64,
interval : i64,
prev : TimeWeightSummaryData,
pad : [u8;3],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff, bit late to do anything about this, but seems like we should have made our pg_type objects aligned so they could be composed without needing padding.

@thatzopoulos thatzopoulos force-pushed the th/integral-stabilization branch 2 times, most recently from 3eecfa5 to 85addbe Compare March 6, 2023 21:07
@thatzopoulos thatzopoulos force-pushed the th/integral-stabilization branch from 85addbe to 79ccfbb Compare March 6, 2023 21:12
@thatzopoulos
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 6, 2023

Build succeeded:

@bors bors bot merged commit f518404 into main Mar 6, 2023
@bors bors bot deleted the th/integral-stabilization branch March 6, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syvb syvb Awaiting requested review from syvb

1 more reviewer

@WireBaron WireBaron WireBaron approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stabilize Integral and interpolated_integral
3 participants
@thatzopoulos @syvb @WireBaron