Skip to content

Stabilize state aggregate #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 7, 2023
Merged

Stabilize state aggregate #723

merged 6 commits into from
Mar 7, 2023

Conversation

syvb
Copy link
Member

@syvb syvb commented Mar 1, 2023 •
edited
Loading

Closes #691.

@syvb syvb force-pushed the sv/state_agg-stable branch 4 times, most recently from 5f5dd75 to 6fee0cf Compare March 1, 2023 19:39
@syvb syvb marked this pull request as ready for review March 1, 2023 20:02
@syvb syvb requested review from WireBaron and thatzopoulos March 2, 2023 13:23
WireBaron
WireBaron reviewed Mar 2, 2023
View reviewed changes
extension/src/state_aggregate.rs
// binary search to find the first time at or after the start time
let slice = agg.combined_durations.as_slice();
let idx = match slice.binary_search_by(|tis| tis.start_time.cmp(&point)) {
Ok(idx) => idx,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no notion of an end time for a state_agg right? So this will simply return the last state for any time stamp past the last time seen?

@syvb syvb requested a review from WireBaron March 6, 2023 19:16
@syvb syvb force-pushed the sv/state_agg-stable branch from 74177c6 to 0443881 Compare March 6, 2023 22:07
@syvb syvb force-pushed the sv/state_agg-stable branch from 0443881 to bdd2fbe Compare March 6, 2023 22:36
@syvb syvb force-pushed the sv/state_agg-stable branch from bdd2fbe to 7ee322d Compare March 6, 2023 23:14
@syvb syvb force-pushed the sv/state_agg-stable branch from 7ee322d to 51c2a52 Compare March 6, 2023 23:26
@syvb
Copy link
Member Author

syvb commented Mar 6, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 7, 2023

Build succeeded:

@bors bors bot merged commit ec79565 into main Mar 7, 2023
@bors bors bot deleted the sv/state_agg-stable branch March 7, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatzopoulos thatzopoulos Awaiting requested review from thatzopoulos

1 more reviewer

@WireBaron WireBaron WireBaron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stabilize timeline aggregate as the new state_aggregate

2 participants

@syvb @WireBaron