Pre-stabilization changes for state_agg - part 1 #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syvb
force-pushed
the
sv/duration_in-extended
branch
from
4d6b612 to
c627db5
Compare
syvb
force-pushed
the
sv/duration_in-extended
branch
from
8956d9e to
1cab5a0
Compare
syvb
changed the title
syvb
commented
Feb 2, 2023
syvb
changed the title
WireBaron
reviewed
Feb 7, 2023
syvb
force-pushed
the
sv/duration_in-extended
branch
from
6cb48a2 to
7ae40d3
Compare
syvb
force-pushed
the
sv/duration_in-extended
branch
from
7ae40d3 to
b7ffc0b
Compare
syvb
force-pushed
the
sv/duration_in-extended
branch
from
d0cd0c3 to
571ace5
Compare
WireBaron
approved these changes
Feb 7, 2023
epgts
approved these changes
Feb 8, 2023
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 8, 2023
692: Pre-stabilization changes for state_agg - part 1 r=Smittyvb a=Smittyvb - Adds optional `start` and `end` parameters to `duration_in` to only get the duration in the specified range. If `end` is omitted all states after `start` are included. `interpolated_duration_in` now uses these ones as well. - Renames `state_agg` -> `compressed_state_agg` (final name TBD), `timeline_agg` -> `state_agg` - Removes mostly unused `next` parameters from interpolated state aggregate functions Closes #687. Related to #691. Co-authored-by: Smitty <[email protected]>
|
Build failed: |
|
@WireBaron looks like this frequency test is flaky. bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startandendparameters toduration_into only get the duration in the specified range. Ifendis omitted all states afterstartare included.interpolated_duration_innow uses these ones as well.state_aggtocompact_state_aggandtimeline_aggtostate_aggnextparameters from interpolated state aggregate functions.Closes #687. Related to #691.