Skip to content

Conversation

jriouovh
Copy link

Go 1.22 is end-of-life since Feb 2025. Use a currently supported version.

Go 1.22 is end-of-life since Feb 2025. Use a currently supported version.

Signed-off-by: Julien Riou <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jul 25, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MetalBlueberry
Copy link
Contributor

Thank you for contributing 🚀

Updating the ci is good to check if the project actually build against the latest version, but the go.mod version should not be updated.

If you check https://go.dev/doc/modules/gomod-ref you can see the version in go mod is the minimum version required to build the library. My understanding is that this means it should not be increased unless a new feature is required. Keeping this values as low as possible allows more people to import this package and use it.

Also, the current state is that we only aim to support the CLI usage officially. This means the actual version used to build the binary should not matter for users.
If you want to import the package and you are worried about different versions.... I'll suggest to carefully test it in your own environment. ( you should do this anyway 🚀 )

So I think at this moment we should not merge this, but I'll discuss with the team the option to run the test suite with different go versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants